chore: CHANGELOG for M5.4 parity coercions (PR #25 )

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge pull request 'fix(py): parity coercions — amount/message types + junior '?' sticky' (#25 ) from fix/py-parity-coercions into main
2026-05-08 00:27:34 +02:00 · 2026-05-07 22:26:39 +00:00 · 2026-05-08 00:26:04 +02:00 · 2026-05-08 00:26:04 +02:00
3 changed files with 20 additions and 5 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog

+## 2026-05-08 00:26 CEST — fix(py): parity coercions — amount/message types + junior '?' sticky
+
+- `scripts/match_payments.py`: added `get_float` helper — non-numeric `amount` values (e.g. `"---"` placeholder rows) now coerce to `0.0` matching Go's `parseFloat` behaviour; `message` field now goes through `get_str` so numeric cell values (bank references) are emitted as strings, matching Go's `fmt.Sprint`.
+- `scripts/views.py`: junior month cell `"?"` text is now sticky across exception overrides. Previously `reconcile` replaced `expected` with the exception amount before the view builder ran, silently turning `"?"` into `"-"` when the override was 0. Fixed by deriving `is_unknown` from `original_expected == "?"` instead of `expected == "?"`. Also aligned tooltip guard: only show Received/Expected for non-unknown months (or when paid > 0), matching Go's `!md.IsUnknown` condition.
+
 ## 2026-05-07 23:51 CEST — feat(py): M5.4 fix #2 — add vs and sync_id to payments tx projection

 - `scripts/match_payments.py`: `fetch_sheet_data` now reads `VS` and `Sync ID` columns and includes `vs`/`sync_id` keys in every tx dict. Previously only 9 columns were projected, causing `make parity` to report extra `vs`/`sync_id` fields on every raw payment row emitted by the Go backend. Values flow through `group_payments_by_person` → `_unwrap_view_model_for_api` to `raw_payments` (adults/juniors) and `grouped_payments` (payments) automatically.
--- a/scripts/match_payments.py
+++ b/scripts/match_payments.py
@@ -255,16 +255,25 @@ def fetch_sheet_data(spreadsheet_id: str, credentials_path: str) -> list[dict]:
                return str(int(v))
            return str(v)

+        def get_float(idx):
+            v = get_val(idx)
+            if isinstance(v, (int, float)):
+                return float(v)
+            try:
+                return float(str(v).strip())
+            except (ValueError, TypeError):
+                return 0.0
+
        tx = {
            "date": format_date(get_val(idx_date)),
-            "amount": get_val(idx_amount),
+            "amount": get_float(idx_amount),
            "manual_fix": get_val(idx_manual),
            "person": get_val(idx_person),
            "purpose": get_val(idx_purpose),
            "inferred_amount": get_val(idx_inferred_amount),
            "sender": get_val(idx_sender),
            "vs": get_str(idx_vs),
-            "message": get_val(idx_message),
+            "message": get_str(idx_message),
            "bank_id": get_val(idx_bank_id),
            "sync_id": get_val(idx_sync_id),
        }
--- a/scripts/views.py
+++ b/scripts/views.py
@@ -310,8 +310,9 @@ def build_juniors_view_model(
            cell_text = "-"
            amount_to_pay = 0

-            if expected == "?" or (isinstance(expected, int) and expected > 0):
-                if expected == "?":
+            is_unknown = original_expected == "?"
+            if is_unknown or (isinstance(expected, int) and expected > 0):
+                if is_unknown:
                    status = "empty"
                    cell_text = f"?{count_str}"
                elif paid >= expected:
@@ -339,7 +340,7 @@ def build_juniors_view_model(
                status = "surplus"
                cell_text = f"PAID {paid}"

-            if (isinstance(expected, int) and expected > 0) or paid > 0:
+            if (not is_unknown and isinstance(expected, int) and expected > 0) or paid > 0:
                tooltip = f"Received: {paid}, Expected: {expected}"
            else:
                tooltip = ""
Author	SHA1	Message	Date
Jan Novak	2f635db2b4	chore: CHANGELOG for M5.4 parity coercions (PR #25 ) All checks were successful Deploy to K8s / deploy (push) Successful in 7s Details Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-08 00:27:34 +02:00
kacerr	709a2f2335	Merge pull request 'fix(py): parity coercions — amount/message types + junior '?' sticky' (#25 ) from fix/py-parity-coercions into main All checks were successful Deploy to K8s / deploy (push) Successful in 8s Details Reviewed-on: #25	2026-05-07 22:26:39 +00:00
Jan Novak	58973473c9	fix(py): make junior '?' cell text sticky across exception overrides All checks were successful Deploy to K8s / deploy (push) Successful in 8s Details Go's build_juniors sets cellText = "?" + countStr whenever md.IsUnknown is true, regardless of whether an exception overrides the expected amount. Python was checking expected == "?" for this branch, but reconcile replaces expected with the exception amount (e.g. 0) before the view builder runs, so the "?" was silently dropped to "-". Fix: derive is_unknown from original_expected == "?" (set before exception substitution) instead of expected == "?". Also align the tooltip guard: Go only shows Received/Expected tooltip for non-unknown months (or when paid > 0), matching the same is_unknown flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-08 00:26:04 +02:00
Jan Novak	b68d95d217	fix(py): coerce amount to float and message to string in tx projection Two remaining make parity diffs vs Go: - amount: non-numeric sheet values like "---" passed through as strings; Go's parseFloat silently returns 0.0 for unparseable values. Add get_float helper that matches that behaviour. - message: numeric cell values (e.g. a bank reference in the message column) passed through as float64; Go's getVal uses fmt.Sprint and always emits a string. Apply get_str to the message field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-08 00:26:04 +02:00