fix: Tolerate diacritic/case/whitespace mismatches in Person column matching
- Add canonical_member_key() in match_payments.py to normalize names via NFKD + lowercase + whitespace-collapse before ledger lookup; resolves payments attributed to e.g. "Maria Maco" to canonical "Mária Maco". Emits logger.info when a non-canonical cell is rescued so sheet typos are visible in logs without losing the payment allocation. - Extend group_payments_by_person() in app.py to accept member_names and re-key raw-payment groups under the canonical attendance-sheet name so the modal's Raw Payments debug section also finds the row correctly. - Add raw payments collapsible section to member detail modal in adults.html and juniors.html for debugging payment attribution issues. - Remove 4 obsolete tests targeting routes /fees, /fees-juniors, /reconcile, /reconcile-juniors that no longer exist; add test_match_payments.py covering canonical key equivalence and reconcile() tolerance end-to-end. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
69
tests/test_match_payments.py
Normal file
69
tests/test_match_payments.py
Normal file
@@ -0,0 +1,69 @@
|
||||
import unittest
|
||||
|
||||
from scripts.match_payments import canonical_member_key, reconcile
|
||||
|
||||
|
||||
class TestCanonicalMemberKey(unittest.TestCase):
|
||||
def test_diacritics_and_case_collapse(self):
|
||||
self.assertEqual(canonical_member_key("Mária Maco"), "maria maco")
|
||||
self.assertEqual(canonical_member_key("MARIA MACO"), "maria maco")
|
||||
self.assertEqual(canonical_member_key("maria maco"), "maria maco")
|
||||
|
||||
def test_whitespace_runs_collapse(self):
|
||||
self.assertEqual(canonical_member_key("Mária Maco"), "maria maco")
|
||||
self.assertEqual(canonical_member_key(" Mária Maco "), "maria maco")
|
||||
|
||||
def test_unknown_name_passes_through_normalized(self):
|
||||
# Two genuinely different names must not collide.
|
||||
self.assertNotEqual(
|
||||
canonical_member_key("Mária Maco"),
|
||||
canonical_member_key("Marek Maco"),
|
||||
)
|
||||
|
||||
|
||||
class TestReconcileTolerantPersonMatching(unittest.TestCase):
|
||||
def _members(self):
|
||||
return [("Mária Maco", "A", {"2026-04": (750, 4)})]
|
||||
|
||||
def _tx(self, person):
|
||||
return {
|
||||
"date": "2026-04-15",
|
||||
"amount": 750,
|
||||
"person": person,
|
||||
"purpose": "2026-04",
|
||||
"inferred_amount": 750,
|
||||
"sender": "Maco Family",
|
||||
"message": "fee",
|
||||
}
|
||||
|
||||
def test_person_without_diacritics_matches(self):
|
||||
result = reconcile(self._members(), ["2026-04"], [self._tx("Maria Maco")], {})
|
||||
|
||||
member = result["members"]["Mária Maco"]
|
||||
self.assertEqual(member["months"]["2026-04"]["paid"], 750)
|
||||
self.assertEqual(len(member["months"]["2026-04"]["transactions"]), 1)
|
||||
self.assertEqual(result["unmatched"], [])
|
||||
|
||||
def test_person_with_extra_whitespace_matches(self):
|
||||
result = reconcile(self._members(), ["2026-04"], [self._tx("Mária Maco")], {})
|
||||
|
||||
self.assertEqual(result["members"]["Mária Maco"]["months"]["2026-04"]["paid"], 750)
|
||||
self.assertEqual(result["unmatched"], [])
|
||||
|
||||
def test_person_lowercase_matches(self):
|
||||
result = reconcile(self._members(), ["2026-04"], [self._tx("mária maco")], {})
|
||||
|
||||
self.assertEqual(result["members"]["Mária Maco"]["months"]["2026-04"]["paid"], 750)
|
||||
self.assertEqual(result["unmatched"], [])
|
||||
|
||||
def test_truly_unknown_person_still_unmatched(self):
|
||||
result = reconcile(
|
||||
self._members(), ["2026-04"], [self._tx("Někdo Neznámý")], {}
|
||||
)
|
||||
|
||||
self.assertEqual(result["members"]["Mária Maco"]["months"]["2026-04"]["paid"], 0)
|
||||
self.assertEqual(len(result["unmatched"]), 1)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user