Jan Novak
ff859ebd84
Create/Get/Delete/ListByTag against real corev1.Pod objects in the same cluster the operator runs in, running an ubuntu/squid container -- picked by actually checking Docker Hub metadata (Canonical-published, rebuilt the same day this was decided, 50M+ pulls) rather than guessing an image reference. It's a public image, so kind nodes pull it directly with no build/load step. providerID is "<namespace>/<podName>", parsed via cache.SplitMetaNamespaceKey -- the same self-contained-providerID reasoning the plan already calls for on the GCP provider's zone-qualified IDs. Pod state maps to InstanceState with Succeeded/Failed/Unknown all collapsing to Terminated, since the reconciler already treats Stopped and Terminated identically; Running-without-PodIP maps to Provisioning so an empty IP is never published. The client is built internally via ctrl.GetConfig() (in-cluster or local kubeconfig, whichever applies), not threaded through the registry Constructor signature -- this is what lets `make run` against a local kind cluster and running in-cluster share the exact same code path with no provider-specific wiring in cmd/main.go. New() is deliberately untested (0% coverage): it's the one function that must never run under `go test`, since it would happily connect to whatever cluster the developer's kubeconfig points at. Tests construct Provider via an unexported newWithClient(client, cfg) instead. ListByTag lists Pods across every namespace (orphan GC needs to find every tagged Pod regardless of where it landed), which means this provider's RBAC has to be a ClusterRole rather than namespace-scoped -- flagged now, wired in Step 10. provider.Config gains KubernetesConfig (replacing MockConfig) and drops the FailWith*/fault-injection surface entirely, since that need is now served by a small in-test stub Provider for reconciler tests (Step 4), not a config-driven mechanism on a real provider package. Tests use sigs.k8s.io/controller-runtime/pkg/client/fake -- real Pod objects, the real client.Client interface -- at 77.6% coverage. make test green across the whole repo. Co-Authored-By: Claude <noreply@anthropic.com>
68 lines
2.2 KiB
Go
68 lines
2.2 KiB
Go
package kubernetes
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
"gitea.home.hrajfrisbee.cz/kacerr/egress-proxies-operator/internal/provider"
|
|
)
|
|
|
|
const proxyContainerName = "squid"
|
|
|
|
// writeConfigAndExec is the container's entrypoint: write the config the
|
|
// SQUID_CONF env var carries to disk, then exec squid against it. Avoids a
|
|
// separate ConfigMap object per proxy instance — there's still only one
|
|
// Kubernetes object (the Pod) to create, track, and clean up per proxy.
|
|
const writeConfigAndExec = `printf '%s' "$SQUID_CONF" > /etc/squid/squid.conf && exec squid -N -f /etc/squid/squid.conf`
|
|
|
|
// buildPod constructs the Pod for a proxy instance. Pure and side-effect
|
|
// free, so it's unit-tested directly without a cluster — the same pattern
|
|
// the GCP provider's buildInsertRequest uses.
|
|
func buildPod(image string, req provider.CreateRequest) *corev1.Pod {
|
|
return &corev1.Pod{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: req.Name,
|
|
Namespace: req.Namespace,
|
|
Labels: map[string]string{
|
|
provider.LabelManaged: provider.LabelManagedYes,
|
|
provider.LabelUID: req.UID,
|
|
},
|
|
},
|
|
Spec: corev1.PodSpec{
|
|
RestartPolicy: corev1.RestartPolicyAlways,
|
|
Containers: []corev1.Container{{
|
|
Name: proxyContainerName,
|
|
Image: image,
|
|
Command: []string{"/bin/sh", "-c"},
|
|
Args: []string{writeConfigAndExec},
|
|
Env: []corev1.EnvVar{{
|
|
Name: "SQUID_CONF",
|
|
Value: squidConf(req.Port),
|
|
}},
|
|
Ports: []corev1.ContainerPort{{
|
|
ContainerPort: req.Port,
|
|
Protocol: corev1.ProtocolTCP,
|
|
}},
|
|
}},
|
|
},
|
|
}
|
|
}
|
|
|
|
// squidConf generates a minimal Squid config listening on port, permissive
|
|
// enough to forward CONNECT and plain HTTP to any destination. Open by
|
|
// design: this is a proxy for a private cluster, not internet-facing, and
|
|
// installing/configuring proxy software is explicitly out of scope for
|
|
// this operator's real (GCP) provider too — cloud-init is passed through
|
|
// there, never interpreted. via/forwarded_for are turned off so the proxy
|
|
// doesn't leak the Pod's identity to the origin.
|
|
func squidConf(port int32) string {
|
|
return fmt.Sprintf(`http_port %d
|
|
acl all src 0.0.0.0/0
|
|
http_access allow all
|
|
via off
|
|
forwarded_for off
|
|
`, port)
|
|
}
|