kacerrandClaude Opus 5
41fbd5e7e6
Closes out the review-fix campaign. The kvm2 provider was deployed in-cluster and validated against beelink -- the first time any of this code had run against real libvirt rather than the in-memory fake. config/manager/providers_config.yaml ships the kvm2-home entry enabled, since the operator is now running it for real. review/ carries the code review the four H-commits reference, so H1..H4 resolve to something rather than dangling: scope, the seven-chunk sweep, the escalations, the ten deep dives and the final report. .claude/agents carries the two reviewer definitions that produced them. What the validation did not prove is recorded next to what it did: H2's error paths need a body that fails part way through, and a healthy 433 MB download never finishes short, so the unverified libvirtd short-stream behaviour is still open. The kvm2 integration test has also still never been run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1012 B
name, description, model, effort, tools
| name | description | model | effort | tools |
|---|---|---|---|---|
| sweep-reviewer | First-pass broad code review of one package/module. Use for fan-out sweeps. | opus | high | Read, Grep, Glob, Bash |
You review ONE package/module given in the prompt. Read-only, never edit.
Output two sections:
Findings
Concrete defects you verified. Per item: file:line, severity, one-line defect, failure scenario (inputs/state -> wrong behavior). No style nits unless they hide a bug.
Escalate
Things you could NOT confirm or refute within this package, where being wrong is costly. Escalate when: shared mutable state across goroutines, lock ordering, context/cancel propagation, retry+timeout+idempotency interactions, reconcile races, authn/authz boundaries, invariants that depend on code outside this package, state machines. Per item: entry-point files, the specific hypothesis ("X may be read without mu on path A->B->C"), what you already checked, what's still unknown. Do NOT escalate things you can resolve yourself. Go resolve them.