kvm2: Create, Get, Delete and ListByTag with the contract tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

internal/provider/kvm2/fake_test.go

@@ -36,6 +36,13 @@ type fakeBackend struct {
 	// sha256 in fixed chunks instead of holding the bytes, for tests that
 	// push more through the fake than they want in memory.
 	discardUploads bool
+	// startDelayPolls, when set, makes DomainCreate leave the domain shut
+	// off; it turns running on the startDelayPolls-th DomainGetState after
+	// that, as a real host that is still booting QEMU would.
+	startDelayPolls int
+	// undefineFlags records the flags of the last DomainUndefineFlags per
+	// domain name.
+	undefineFlags map[string]libvirt.DomainUndefineFlagsValues
 
 	calls  map[string]int
 	log    []string
@@ -51,6 +58,9 @@ type fakeDomain struct {
 	addrs    map[uint32][]libvirt.DomainInterface
 	uuid     libvirt.UUID
 	id       int32
+	// pendingStart counts the DomainGetState calls left before a delayed
+	// start (see startDelayPolls) turns the domain running.
+	pendingStart int
 }
 
 type fakePool struct {
@@ -72,15 +82,16 @@ const fakePoolName = "default"
 
 func newFakeBackend() *fakeBackend {
 	return &fakeBackend{
-		mu:       &sync.Mutex{},
-		domains:  make(map[string]*fakeDomain),
-		pools:    map[string]*fakePool{fakePoolName: newFakePool()},
-		hostname: "fake-host",
-		version:  11006000,
-		hooks:    make(map[string]func() error),
-		block:    make(map[string]chan struct{}),
-		calls:    make(map[string]int),
-		deadCh:   make(chan struct{}),
+		mu:            &sync.Mutex{},
+		domains:       make(map[string]*fakeDomain),
+		pools:         map[string]*fakePool{fakePoolName: newFakePool()},
+		hostname:      "fake-host",
+		version:       11006000,
+		hooks:         make(map[string]func() error),
+		block:         make(map[string]chan struct{}),
+		undefineFlags: make(map[string]libvirt.DomainUndefineFlagsValues),
+		calls:         make(map[string]int),
+		deadCh:        make(chan struct{}),
 	}
 }
 
@@ -97,6 +108,7 @@ func (f *fakeBackend) twin() *fakeBackend {
 		hooks:          make(map[string]func() error),
 		block:          make(map[string]chan struct{}),
 		discardUploads: f.discardUploads,
+		undefineFlags:  make(map[string]libvirt.DomainUndefineFlagsValues),
 		calls:          make(map[string]int),
 		deadCh:         make(chan struct{}),
 	}
@@ -279,6 +291,10 @@ func (f *fakeBackend) DomainCreate(ctx context.Context, dom libvirt.Domain) erro
 	if isActive(d.state) {
 		return fakeErr(libvirt.ErrOperationInvalid, "Requested operation is not valid: domain is already running")
 	}
+	if f.startDelayPolls > 0 {
+		d.pendingStart = f.startDelayPolls
+		return nil
+	}
 	d.state = libvirt.DomainRunning
 	d.id = int32(len(f.domains))
 	return nil
@@ -301,7 +317,7 @@ func (f *fakeBackend) DomainDestroy(ctx context.Context, dom libvirt.Domain) err
 	return nil
 }
 
-func (f *fakeBackend) DomainUndefineFlags(ctx context.Context, dom libvirt.Domain, _ libvirt.DomainUndefineFlagsValues) error {
+func (f *fakeBackend) DomainUndefineFlags(ctx context.Context, dom libvirt.Domain, flags libvirt.DomainUndefineFlagsValues) error {
 	if err := f.enter(ctx, "DomainUndefineFlags"); err != nil {
 		return err
 	}
@@ -310,6 +326,7 @@ func (f *fakeBackend) DomainUndefineFlags(ctx context.Context, dom libvirt.Domai
 	if _, err := f.domain(dom.Name); err != nil {
 		return err
 	}
+	f.undefineFlags[dom.Name] = flags
 	delete(f.domains, dom.Name)
 	return nil
 }
@@ -324,6 +341,13 @@ func (f *fakeBackend) DomainGetState(ctx context.Context, dom libvirt.Domain, _
 	if err != nil {
 		return 0, 0, err
 	}
+	if d.pendingStart > 0 {
+		d.pendingStart--
+		if d.pendingStart == 0 {
+			d.state = libvirt.DomainRunning
+			d.id = int32(len(f.domains))
+		}
+	}
 	return int32(d.state), 0, nil
 }