kvm2: Create, Get, Delete and ListByTag with the contract tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-16 19:23:49 +00:00
parent 6b3c985b4a
commit 794a2aef3d
14 changed files with 2120 additions and 63 deletions
@@ -8,7 +8,7 @@ Plan: [docs/plans/2026-09-16-1333-kvm2-provider.md](../plans/2026-09-16-1333-kvm
 - [x] Step 3 — Pure builders: domain and volume XML, metadata, seed
 - [x] Step 4 — Transport, seam, decorator, fakes
 - [x] Step 5 — Image cache and pool-space precheck
- [ ] Step 6 — The four contract methods
+- [x] Step 6 — The four contract methods
 - [ ] Step 7 — Checker and the CRD comment
 - [ ] Step 8 — Deployment files, Makefile, integration test
 - [ ] Step 9 — Documentation
@@ -210,3 +210,43 @@ grep -n 'context.Background()' internal/provider/kvm2/*.go | grep -v _test.go  #
 ```

 All `ok`. Attestation: "files read outside the allowed set: none".
+
+## Step 6 — The four contract methods
+
+2026-09-16 18:36. Fifth subagent step: `create.go`, `get.go`, `delete.go`,
+`list.go` and five test files (the package now has 150 top-level tests).
+Create follows spec entry 10 step for step under a per-name lock, with the
+adoption guard, the quota precheck, the image cache, an overlay that is
+reused and a seed that is always rebuilt, file-type disks from resolved
+paths, the metadata element in the define call, and a wait for running
+capped at two minutes. Get maps only `ErrNoDomain` to NotFound, prefers the
+guest agent over ARP, and reads UID and CreatedAt back every time. Delete is
+idempotent at every step and a no-op success for an unconfigured host.
+ListByTag fails whole per host and skips single unreadable domains.
+
+Decisions the agent made, accepted: the adoption path also waits for
+running, so a repeat Create on a shut-off domain blocks like a first one;
+`address` and `ListByTag` propagate ctx cancellation instead of reading it as
+"no address" or "skip", so a cancelled Get is Transient rather than a false
+Provisioning; NotFound from Get gets its own V(1) line because polling to
+NotFound is expected; the domain XML rides on the `domain defined` line at
+V(2). Flagged, not solved: adopting a paused domain fails Transient on every
+retry (`DomainCreate` refuses and the wait expires), which the spec does not
+cover; recorded as a known gap for the docs step.
+
+The agent found a one-word conflict between the brief and the spec
+(`DomainAffectCurrent` versus `DomainAffectConfig` for `DomainGetMetadata`);
+the code uses `DomainAffectCurrent`, and spec entry 8 was corrected to
+match in this commit.
+
+Commands (agent and orchestrator):
+
+```sh
+gofmt -l ./internal/provider/kvm2 ; go vet ./internal/provider/kvm2/ && go test -race -count=2 ./internal/provider/kvm2/
+go build ./... && go test -short ./...
+grep -n 'CloudInit' internal/provider/kvm2/create.go          # only len(req.CloudInit) and the seed builder call
+grep -n 'not implemented' internal/provider/kvm2/*.go          # empty
+grep -n 'provider.Wrap(' internal/provider/kvm2/*.go | grep -v _test.go | grep -v 'p.name'   # empty
+```
+
+All `ok`. Attestation: "files read outside the allowed set: none".